mv,cp: fix xattr TOCTOU by using file descriptor-based operations by sylvestre · Pull Request #10545 · uutils/coreutils

sylvestre · 2026-01-28T21:09:40Z

github-actions · 2026-01-28T21:57:21Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-28T22:35:41Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-02-11T12:14:40Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/cp/sparse-2 is now being skipped but was previously passing.

codspeed-hq · 2026-02-21T21:04:50Z

Merging this PR will not alter performance

✅ 303 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing sylvestre:issue-10014 (be02dd9) with main (6e18efb)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-02-21T21:04:54Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-02-21T21:31:31Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-02-21T21:44:03Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

github-actions · 2026-02-21T21:58:18Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-02-24T10:25:21Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-03-16T22:10:41Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!

github-actions · 2026-03-17T10:54:31Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/file-perm-race. tests/cp/file-perm-race is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/expand/bounded-memory is now passing!

github-actions · 2026-03-18T10:22:12Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/existing-perm-race. tests/cp/existing-perm-race is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/sparse. tests/cp/sparse is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/sparse-2. tests/cp/sparse-2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/sparse-extents-2. tests/cp/sparse-extents-2 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!

github-actions · 2026-03-18T22:17:33Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tac/tac-2-nonseekable. tests/tac/tac-2-nonseekable is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/tail-n0f is now passing!

github-actions · 2026-03-18T22:39:08Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

github-actions · 2026-03-23T06:53:12Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/dd/no-allocate is now passing!

github-actions · 2026-03-23T09:57:52Z

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

Closes: uutils#10014

github-actions · 2026-03-31T13:20:29Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/cp/link-heap is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

uutils deleted a comment from github-actions Bot Jan 28, 2026

sylvestre force-pushed the issue-10014 branch from 50618a3 to 2598f34 Compare January 28, 2026 22:26

sylvestre force-pushed the issue-10014 branch 2 times, most recently from 6dda6b4 to 3f06bad Compare February 21, 2026 21:03

sylvestre force-pushed the issue-10014 branch from 3f06bad to 9707371 Compare February 21, 2026 21:34

sylvestre force-pushed the issue-10014 branch from 9707371 to c857f11 Compare February 21, 2026 21:50

sylvestre force-pushed the issue-10014 branch from c857f11 to 6e40932 Compare February 24, 2026 09:52

sylvestre requested review from ChrisDryden and cakebaker February 26, 2026 20:35

sylvestre marked this pull request as ready for review February 26, 2026 20:36

sylvestre force-pushed the issue-10014 branch 2 times, most recently from cf75720 to 1514ccd Compare March 16, 2026 21:59

sylvestre force-pushed the issue-10014 branch 2 times, most recently from 35596ca to 5fa39b8 Compare March 17, 2026 10:45

sylvestre force-pushed the issue-10014 branch from 5fa39b8 to 8d55b2a Compare March 18, 2026 10:10

sylvestre force-pushed the issue-10014 branch 3 times, most recently from 867b6a0 to 09664a9 Compare March 18, 2026 22:16

sylvestre force-pushed the issue-10014 branch 3 times, most recently from 0211168 to 7f35960 Compare March 23, 2026 06:39

sylvestre force-pushed the issue-10014 branch from 7f35960 to 24507dc Compare March 23, 2026 09:49

mv,cp: fix xattr TOCTOU by using file descriptor-based operations

be02dd9

Closes: uutils#10014

sylvestre force-pushed the issue-10014 branch from 24507dc to be02dd9 Compare March 31, 2026 13:02

Uh oh!

Conversation

sylvestre commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Feb 11, 2026

Uh oh!

codspeed-hq Bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions Bot commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 21, 2026

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

github-actions Bot commented Mar 16, 2026

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 23, 2026

Uh oh!

github-actions Bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codspeed-hq Bot commented Feb 21, 2026 •

edited

Loading